Project

General

Profile

Actions
Copy link

Bug #710

closed

Invalid manifest string crashes the transpiler.

Added by Brian Flanagan over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
High
Assignee:
Francois Lionet
Target version:
1.0.0 (B7)
Start date:
03/31/2021
Due date:
% Done:

0%

Estimated time:
1:00 h
Affected version:
1.0.0 (B6a)

Description

I consider anything that crashes the transpiler as a high priority.

IMO, instead of crashing the compiler, this should just display a warning, and assume the default.
At the very least, an error message should be displayed: Unrecognized manifest name.

Example:

#manifest: "pc"

The result is some cryptic error message. (see snapshot)
Instead, it should read something like:

Unrecognized manifest name: pc

Files

Cryptic_Bad_Manifest_Error.png (66.2 KB) Cryptic_Bad_Manifest_Error.png Cryptic error message. Brian Flanagan, 04/01/2021 12:08 AM
Actions
Copy link
 #1

Updated by Francois Lionet over 3 years ago

  • Status changed from New to Resolved
  • Assignee set to Francois Lionet

Fixed!

Actions
Copy link
 #2

Updated by Brian Flanagan over 3 years ago

  • Status changed from Resolved to Closed
  • Target version set to 1.0.0 (B7)

Corrected in 1.0.0 (B7)
AOZ now assumes default manifest if an invalid manifest ID is used.

NOTE: It should, however, display a warning error of the invalid manifest ID when transpiling.
For example: If the following #manifest tag is used:

#manifest: "zzz"

...then we should see an error in the "AOZ Messages" window, something like this:

Warning:  Bad manifest ID "zzz" at line 1.  Assuming default.
Actions
Copy link

Also available in: Atom PDF