Project

General

Profile

Actions

Bug #396

open

Load IFF distorts the images loaded. It also gets the background color wrong sometimes.

Added by Brian Flanagan about 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Target version:
Start date:
06/20/2020
Due date:
% Done:

0%

Estimated time:
8:00 h
Affected version:

Description

Whatever IFF decoder we're using in Load IFF stretches the IFF images horizontally, and results in an image with many artifacts, both horizontally and vertically. The attached image shows an accurate IFF graphic on the left (generated by Dalton Tulou's Quick Look plugin for macOS),
compared to that generated by AOZ's Load IFF on the right.

I would highly recommend replacing whatever decoder we're using now with Matthias Wiesmann's IFF decoder, since it seems to be the most comprehensive version so far: https://wiesmann.codiferes.net/wordpress/?page_id=17479 It's in JavaScript... under a GPL3 public license.

It works with standard Color Palette, EHB, IFF, ILBM, HAM (including HAM-6 and HAM-8), SHAM, and RGB24 images, including color cycling! From the examples on his website, it appears to be very accurate as well.


Files

Screen Shot 2020-06-20 at 10.11.05 AM.png (36.9 KB) Screen Shot 2020-06-20 at 10.11.05 AM.png Illustration of distortion Brian Flanagan, 06/20/2020 03:13 PM
Screen Shot 2020-06-20 at 10.24.58 AM.png (51.8 KB) Screen Shot 2020-06-20 at 10.24.58 AM.png Vertically, the images are the same height, but you can see the horizontal stretching and distortion. Brian Flanagan, 06/20/2020 03:26 PM
Screen Shot 2020-06-20 at 10.58.14 AM.png (69.7 KB) Screen Shot 2020-06-20 at 10.58.14 AM.png The distortion is even worse on this image, and you can see the incorrect background color. (It should be black.) Brian Flanagan, 06/20/2020 04:00 PM
Actions #2

Updated by Brian Flanagan about 4 years ago

Besides the image distortion, it also gets the background color wrong simetimes.

Actions #3

Updated by Brian Flanagan about 4 years ago

I looked inside the guts of AOZ, and to my surprise, I found we are using Weismann's library.

All I can figure out is that there must be something wrong with how we're using it.

When I load the graphics with his demo, they are in the proper aspect. When I load them with AOZ, they're distorted.

I'll check and see if the incorrect background color is their problem or ours, and post an update here when I find out.

Actions #4

Updated by Brian Flanagan about 4 years ago

  • Affected version changed from 0.9.9.2 to 0.9.9.3

I looked inside the guts of AOZ, and to my surprise, I found we are using Weismann's library.

All I can figure out is that there must be something wrong with how we're using it.

When I load the graphics with his demo, they are in the proper aspect. When I load them with AOZ, they're distorted.

I'll check and see if the incorrect background color is their problem or ours, and post an update here when I find out.
I also corrected the Affected version to 0.9.9.3 (test2).

Actions #5

Updated by Brian Flanagan almost 4 years ago

  • Estimated time set to 8:00 h
  • Affected version changed from 0.9.9.3 to Beta RC2

Still a problem.

Actions #6

Updated by Francois Lionet almost 4 years ago

  • Status changed from New to Resolved
  • Assignee set to Francois Lionet
  • Target version set to Beta RC4

Should be corrected. I was resizing the image to the size of the screen in case there was no indication of a screen to open.

Actions

Also available in: Atom PDF